Repository navigation
Extend close time logic to differentiate between the claimant and other users #1470
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
44 commits
Select commit
Hold shift + click to select a range
6b9c954
Split out help channel idle time constants
ChrisLovering ce86169
Set a reasonable default for `idle_minutes_others`.
ChrisLovering 243d465
Update help availible footer
ChrisLovering b3c66a6
Extend close time logic to differentiate between the claimant and oth…
ChrisLovering 9503a2e
Improve trace message.
ChrisLovering 61e17c8
Improve availible channel embed footer
ChrisLovering 12a73f2
Improve docs strings and variable names within the help channel system
ChrisLovering fce7fb9
Repurpose unanswered cache for storing non-claimant last message times
ChrisLovering 5003059
Update function name to describe new behaviour.
ChrisLovering 9a3c946
Delete cached claimant message time.
ChrisLovering 6a954de
Move return behaviour comments to in-line rather than docstring.
ChrisLovering e962aa5
If the channel is empty, determine closing time based on last message.
ChrisLovering 3fe9a39
Determine closing time from last message if either cache is empty, ra…
ChrisLovering 72eb71d
More descriptive comment for when an if block is entered
ChrisLovering 457cb14
reset cache on bot start, stats for different close reasons
laundmo cfdff9e
passing pre-commit
laundmo 1eaf201
run precommit with all deps
laundmo 502c097
Merge pull request #1476 from laundmo/help-channel-closing-delay-changes
ChrisLovering afe7aff
Use fallback behaviour during cog init
ChrisLovering 2381428
Use claiment idle time as default idle minutes.
ChrisLovering 2ac3e1f
Add back seperation whitespace
ChrisLovering 65c0097
Don't prepend command closes with auto
ChrisLovering 9f576bc
Change help channel logic to use timezone naive stamps
ChrisLovering 258086f
Remove unneeded cache clearing
ChrisLovering b1b105a
Check for close on command explictly.
ChrisLovering b8eef95
Schedule channels just opened using claimant configured idle time
ChrisLovering ef38220
update help channel on_message docstring to reflect unchanged respons…
ChrisLovering 93b9d41
Only fetch claimant id once
ChrisLovering 3114b48
Change help channel caching logic to use timezone naive stamps
ChrisLovering bae3d6a
Create utc datetime objects from timestamps
ChrisLovering f228659
Refactor help channel update message cache function for clearer flow
ChrisLovering d7eb48a
Refactor if block within help channel system to be more readable
ChrisLovering a3a5fc4
Reset a channel's non-claimant cache on claim, to indicate that the s…
ChrisLovering a951789
Convert to timestamp before posting to redis
ChrisLovering fea068f
Fix error when converting non claimant message
ChrisLovering 519398b
Add 1 second due to POSIX timestamps being lower resolution than date…
ChrisLovering a732e0a
Use correct constant for each type of help session user
ChrisLovering cc3c474
Switch to datetime.fromtimestamp() to avoid over-compensation
ChrisLovering 07e3b45
Update arrow to 1.0.3
MarkKoz b71a1e5
HelpChannels: use aware datetimes everywhere
MarkKoz feb9b22
HelpChannels: refactor get_closing_time
MarkKoz 96037aa
Enumerate all possible values for closed_on in docstring
ChrisLovering 2621f24
Change to an Enum for possible closing reasons
ChrisLovering 57fb66d
Fix copy & paste error in closing reason enum
ChrisLovering File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.