Skip to content

Don't allow doubled actions. E.g. you shouldn't be able to mute muted users. #98

Closed

Description

@pydis-bot

Originally posted by Leon Sandøy:

You shouldn't be able to unwatch an unwatched user, or mute a muted user. The bot should simply say "oops, that user is already muted / banned / is not on the server (if you try to kick) / isn't currently being watched / ..."

Go through the bot, find cases like these, and fix'em.

Activity

  1. pydis-bot commented on Nov 17, 2018

    @pydis-bot
    Author

    Comment from Johannes Christ:

    "am already doing x" and "can not do x" are two different things, if the bot can't do something, it should give an error message, and if you try to e.g. mute a user that's already muted, it should just say "user is already x, no action taken"

  2. pydis-bot commented on Nov 17, 2018

    @pydis-bot
    Author

    Comment from Leon Sandøy:

    I mean, currently the bot can mute people who are already muted. It just shouldn't be able to.

  3. MarkKoz commented on Sep 27, 2019

    @MarkKoz
    Contributor

    At this point, moderation and watch channel commands already check if infractions exist before carrying them out. Closed in favour of #362

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    a: moderationRelated to community moderation functionality: (moderation, defcon, verification)t: bugSomething isn't working

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions