Skip to content

Remove unsupported Python 2.4 and 2.5 code - #682

Merged
josegonzalez merged 5 commits into
python-diamond:masterfrom
hugovk:patch-1
Mar 15, 2018
Merged

josegonzalez merged 5 commits into
python-diamond:masterfrom
hugovk:patch-1

Conversation

@hugovk

@hugovk hugovk commented Oct 14, 2017

Copy link
Copy Markdown
Contributor

No description provided.

@hugovk hugovk changed the title Remove commented 2.5, it's no longer supported Remove unsupported Python 2.4 and 2.5 code Oct 14, 2017
@coveralls

coveralls commented Oct 14, 2017 •

Copy link
Copy Markdown

Coverage Status

Coverage remained the same at 24.667% when pulling 2d60560 on hugovk:patch-1 into f2bece4 on python-diamond:master.

@coveralls

coveralls commented Oct 14, 2017 •

Copy link
Copy Markdown

Coverage Status

Coverage remained the same at 24.667% when pulling 2d60560 on hugovk:patch-1 into f2bece4 on python-diamond:master.

@coveralls

coveralls commented Oct 14, 2017 •

Copy link
Copy Markdown

Coverage Status

Coverage increased (+0.04%) to 24.702% when pulling c115489 on hugovk:patch-1 into f2bece4 on python-diamond:master.

@coveralls

coveralls commented Oct 14, 2017 •

Copy link
Copy Markdown

Coverage Status

Coverage increased (+0.04%) to 24.702% when pulling 6d9e302 on hugovk:patch-1 into f2bece4 on python-diamond:master.

@coveralls

coveralls commented Oct 14, 2017 •

Copy link
Copy Markdown

Coverage Status

Coverage increased (+0.04%) to 24.702% when pulling 6d9e302 on hugovk:patch-1 into f2bece4 on python-diamond:master.

@coveralls

coveralls commented Oct 14, 2017 •

Copy link
Copy Markdown

Coverage Status

Coverage increased (+0.04%) to 24.702% when pulling 1b950b9 on hugovk:patch-1 into f2bece4 on python-diamond:master.

@hugovk

hugovk commented Nov 1, 2017

Copy link
Copy Markdown
Contributor Author

Here's the pip installs for diamond from PyPI for the last month:

$ pypinfo --percent --pip diamond pyversion
python_version percent download_count
-------------- ------- --------------
2.7              98.0%         27,185
2.6               1.8%            509
3.6               0.1%             22
3.5               0.0%              8
3.4               0.0%              3

@hugovk

hugovk commented Nov 16, 2017

Copy link
Copy Markdown
Contributor Author

@shortdudey123 Hello, any thoughts on this PR? Thanks!

@josegonzalez
josegonzalez merged commit 8638391 into python-diamond:master Mar 15, 2018
@hugovk
hugovk deleted the patch-1 branch March 15, 2018 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants