Skip to content

Key time zone names by canonical IANA zone IDs - #1417

Merged
akx merged 1 commit into
masterfrom
fix-tz-name-aliases
Oct 30, 2026
Merged

akx merged 1 commit into
masterfrom
fix-tz-name-aliases

Conversation

@akx

@akx akx commented Oct 30, 2026 •

Copy link
Copy Markdown
Member

Augments #1220: zone_aliases maps legacy CLDR zone IDs to canonical IANA IDs but we missed meta_zones and per-locale time_zones. Also use the last component of the zone ID as the fallback exemplar city, per UTS35, so e.g. America/Indiana/Indianapolis gives "Indianapolis".

Fixes #1260
Closes #1276 (this being the more correct fix)

@akx akx added this to the Babel 2.19 milestone Oct 30, 2026
@akx
akx marked this pull request as ready for review October 30, 2026 08:42
@codecov

codecov Bot commented Oct 30, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 93.52%. Comparing base (95e0487) to head (b5ed2ab).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1417      +/-   ##
==========================================
+ Coverage   93.51%   93.52%   +0.01%     
==========================================
  Files          27       27              
  Lines        4932     4930       -2     
==========================================
- Hits         4612     4611       -1     
+ Misses        320      319       -1     
Flag Coverage Δ
macos-14-3.10 92.61% <100.00%> (+0.01%) ⬆️
macos-14-3.11 92.55% <100.00%> (+0.01%) ⬆️
macos-14-3.12 92.75% <100.00%> (+0.01%) ⬆️
macos-14-3.13 92.75% <100.00%> (+0.01%) ⬆️
macos-14-3.14 92.73% <100.00%> (+0.01%) ⬆️
macos-14-3.15 92.73% <100.00%> (+0.01%) ⬆️
macos-14-3.8 92.49% <100.00%> (+0.01%) ⬆️
macos-14-3.9 92.55% <100.00%> (+0.01%) ⬆️
macos-14-pypy3.10 92.61% <100.00%> (+0.01%) ⬆️
ubuntu-24.04-3.10 92.63% <100.00%> (+0.01%) ⬆️
ubuntu-24.04-3.11 92.57% <100.00%> (+0.01%) ⬆️
ubuntu-24.04-3.12 92.77% <100.00%> (+0.01%) ⬆️
ubuntu-24.04-3.13 92.77% <100.00%> (+0.01%) ⬆️
ubuntu-24.04-3.14 92.75% <100.00%> (+0.01%) ⬆️
ubuntu-24.04-3.15 92.75% <100.00%> (+0.01%) ⬆️
ubuntu-24.04-3.8 92.51% <100.00%> (+0.01%) ⬆️
ubuntu-24.04-3.9 92.57% <100.00%> (+0.01%) ⬆️
ubuntu-24.04-pypy3.10 92.63% <100.00%> (+0.01%) ⬆️
windows-2022-3.10 92.62% <100.00%> (+0.01%) ⬆️
windows-2022-3.11 92.56% <100.00%> (+0.01%) ⬆️
windows-2022-3.12 92.77% <100.00%> (+0.01%) ⬆️
windows-2022-3.13 92.77% <100.00%> (+0.01%) ⬆️
windows-2022-3.14 92.75% <100.00%> (+0.01%) ⬆️
windows-2022-3.15 92.75% <100.00%> (+0.01%) ⬆️
windows-2022-3.8 92.60% <100.00%> (+0.01%) ⬆️
windows-2022-3.9 92.56% <100.00%> (+0.01%) ⬆️
windows-2022-pypy3.10 92.62% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@codspeed

codspeed Bot commented Oct 30, 2026 •

Copy link
Copy Markdown

Merging this PR will not alter performance

✅ 88 untouched benchmarks


Comparing fix-tz-name-aliases (b5ed2ab) with master (95e0487)

Open in CodSpeed

Augments #1220: zone_aliases maps legacy CLDR zone IDs to canonical IANA IDs
but we missed meta_zones and per-locale time_zones.

Also use the last component of the zone ID as the fallback exemplar city,
per UTS #35, so e.g. America/Indiana/Indianapolis gives "Indianapolis".

Fixes #1260
@akx
akx force-pushed the fix-tz-name-aliases branch from 881dd02 to b5ed2ab Compare October 30, 2026 08:52
@akx
akx enabled auto-merge (squash) October 30, 2026 08:52
@akx
akx merged commit 1fcf0d1 into master Oct 30, 2026
41 checks passed
@akx
akx deleted the fix-tz-name-aliases branch October 30, 2026 08:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

America/Indiana/Indianapolis timezone does not display correctly

1 participant