Skip to content

Python 3.7 warnings #607

Closed
Closed

Description

@tirkarthi

Python 3.7 introduced a warning with respect to collections that will be removed in 3.8 making the project incompatible with 3.8.

Found at https://travis-ci.org/python/cpython/jobs/446051148#L2596

/home/travis/build/python/cpython/Doc/venv/lib/python3.8/site-packages/pkg_resources/_vendor/pyparsing.py:3226: DeprecationWarning: Using or importing the ABCs from 'collections' instead of from 'collections.abc' is deprecated, and in 3.8 it will stop working

Sample fix : pallets/markupsafe#98

Activity

  1. akx commented on Oct 25, 2018

    @akx
    Member

    The warning seems to originate from pkg_resources's vendored version of pyparsing.
    pkg_resources is not a dependency of Babel's, so this is probably not a Babel bug.

    Closing, but please let me know if I'm wrong!

  2. tirkarthi commented on Oct 25, 2018

    @tirkarthi
    Author

    Sorry, my bad I copy pasted the wrong line for reference. Please find the actual warning as below. I checked master and the line is still present so the warning is valid. I would request reopening this.

    /home/travis/build/python/cpython/Doc/venv/lib/python3.8/site-packages/babel/localedata.py:17: DeprecationWarning: Using or importing the ABCs from 'collections' instead of from 'collections.abc' is deprecated, and in 3.8 it will stop working

  3. akx commented on Oct 25, 2018

    @akx
    Member

    Ah, that's more like it then. Reopening :)

  4. reopened this on Oct 25, 2018
  5. tirkarthi commented on Oct 25, 2018

    @tirkarthi
    Author

    Thanks, I guess it's the only place. I will grep for similar places if any and raise a PR. Also adding 3.7 to Travis might help which I can add as part of the same PR if it's ok.

  6. akx commented on Oct 25, 2018

    @akx
    Member

    Please do! :)

  7. tirkarthi commented on Nov 27, 2018

    @tirkarthi
    Author

    Fixed with #609 closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions