Repository navigation
Accelerator.add() utility function - #482
Open
gubaidulinvadim wants to merge 1 commit into
Open
gubaidulinvadim wants to merge 1 commit into
gubaidulinvadim wants to merge 1 commit into
Conversation
…element to all available holders)
GamelinAl
reviewed
Oct 26, 2026
GamelinAl
left a comment
GamelinAl
left a comment
Member
There was a problem hiding this comment.
Looks good.
An improvement would be to do this in a try/except block and to remove the names added so far from every holder in the except block. That way if it fails in the middle the configuration is still the starting one.
Member
Author
|
Arhg, interactive use will have objects dangling even if error is thrown... I'll fix it but there's no nice solution because you need to keep track of elements added during the function call. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added Accelerator.add() utility function to add elements to all modes and holders.
Resolves #420