Skip to content
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/Data/Map/Internal.purs
Original file line number Diff line number Diff line change
Expand Up @@ -603,10 +603,10 @@ unionWith f m1 m2 = foldl go m2 (toUnfoldable m1 :: List (Tuple k v))
where
go m (Tuple k v) = alter (Just <<< maybe v (f v)) k m

-- | Compute the union of two maps, preferring values from the first map in the case
-- | Compute the union of two maps, preferring values from the second map in the case
-- | of duplicate keys
union :: forall k v. Ord k => Map k v -> Map k v -> Map k v
union = unionWith const
union = unionWith (\_ x -> x)

-- | Compute the union of a collection of maps
unions :: forall k v f. Ord k => Foldable f => f (Map k v) -> Map k v
Expand Down
12 changes: 8 additions & 4 deletions test/Test/Data/Map.purs
Original file line number Diff line number Diff line change
Expand Up @@ -176,6 +176,10 @@ mapTests = do
groupBy ((==) `on` fst) <<< sortBy (compare `on` fst) in
M.fromFoldableWith (<>) arr === f (arr :: List (Tuple String String))

log "fromFoldable (a <> b) = fromFoldable a <> fromFoldable b, for arrays a, b"
quickCheck $ \a b ->
M.fromFoldable (a <> b) === M.fromFoldable a <> M.fromFoldable (b :: Array (Tuple String String))

log "toUnfoldable is sorted"
quickCheck $ \(TestMap m) ->
let list = M.toUnfoldable (m :: M.Map SmallKey Int)
Expand All @@ -184,15 +188,15 @@ mapTests = do

log "Lookup from union"
quickCheck $ \(TestMap m1) (TestMap m2) k ->
M.lookup (smallKey k) (M.union m1 m2) == (case M.lookup k m1 of
Nothing -> M.lookup k m2
M.lookup (smallKey k) (M.union m1 m2) == (case M.lookup k m2 of
Nothing -> M.lookup k m1
Just v -> Just (number v)) <?> ("m1: " <> show m1 <> ", m2: " <> show m2 <> ", k: " <> show k <> ", v1: " <> show (M.lookup k m1) <> ", v2: " <> show (M.lookup k m2) <> ", union: " <> show (M.union m1 m2))

log "Union is idempotent"
quickCheck $ \(TestMap m1) (TestMap m2) -> (m1 `M.union` m2) == ((m1 `M.union` m2) `M.union` (m2 :: M.Map SmallKey Int))

log "Union prefers left"
quickCheck $ \(TestMap m1) (TestMap m2) k -> M.lookup k (M.union m1 (m2 :: M.Map SmallKey Int)) == (M.lookup k m1 <|> M.lookup k m2)
log "Union prefers right"
quickCheck $ \(TestMap m1) (TestMap m2) k -> M.lookup k (M.union m1 (m2 :: M.Map SmallKey Int)) == (M.lookup k m2 <|> M.lookup k m1)

log "unionWith"
for_ [Tuple (+) 0, Tuple (*) 1] $ \(Tuple op ident) ->
Expand Down