Skip to content

Explicitly use join - #212

Merged
JordanMartinez merged 1 commit into
purescript:masterfrom
Masynchin:join
Sep 19, 2022
Merged

JordanMartinez merged 1 commit into
purescript:masterfrom
Masynchin:join

Conversation

@Masynchin

Copy link
Copy Markdown
Contributor

Description of the change

Use join instead of its copied implementation.


Checklist:

  • Added the change to the changelog's "Unreleased" section with a reference to this PR (e.g. "- Made a change (#0000)")
  • Linked any existing issues or proposals that this pull request should close
  • Updated or added relevant documentation
  • Added a test for the contribution (if applicable)

@Masynchin

Copy link
Copy Markdown
Contributor Author

I am waiting for approval, so CI can check whether this changes are safe. There is no contributing guide, so I didn't run tests by myself.

@Masynchin

Copy link
Copy Markdown
Contributor Author

@JordanMartinez ping!

@JordanMartinez

Copy link
Copy Markdown
Contributor

@garyb Can we get an approval here?

@JordanMartinez
JordanMartinez merged commit 26e03e3 into purescript:master Sep 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants