You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
nub for lazy lists. Don't know of a good way to fix this. The strict nub strategy of Match nub* functions with Array #179 cannot be applied here because you can't reverse an infinite lazy list.
We should ideally setup stack-safety tests for every function. To help make those tests run faster, we could shrink the v8 stack size with something like --stack_size=10 (default is 984 kB).
I would prefer that we test with lists which are large enough to blow the stack than shrink the stack artificially, as we ideally ought to be testing with large inputs anyway, e.g. so that we are more likely to notice if we make a change which unintentionally makes some functions much slower for large inputs.
Activity
hdgarrood commentedon Jan 16, 2021
I would prefer that we test with lists which are large enough to blow the stack than shrink the stack artificially, as we ideally ought to be testing with large inputs anyway, e.g. so that we are more likely to notice if we make a change which unintentionally makes some functions much slower for large inputs.
imcotton commentedon May 10, 2021
From Data.List.Lazy
elemIndexelemLastIndexfindLastIndexfindIndex<--- caused bypurescript-lists/src/Data/List/Lazy.purs
Lines 317 to 327 in 6383c4f
elldritch commentedon Dec 9, 2021
groupalso does not appear to be stack-safe.elldritch commentedon Dec 14, 2021
It appears that
concatis also not stack-safe?garyb commentedon Dec 14, 2021
Yeah, seems so -
concatis implemented withbindwhich isn't stack safe:purescript-lists/src/Data/List/Types.purs
Lines 165 to 167 in 68bce83