Skip to content
This repository was archived by the owner on Sep 10, 2026. It is now read-only.

Fix polymer-cli test by specifying update-notifier version - #57

Merged
pcj merged 1 commit into
pubref:masterfrom
Zetten:PolymerCli
Feb 6, 2018
Merged

pcj merged 1 commit into
pubref:masterfrom
Zetten:PolymerCli

Conversation

@Zetten

@Zetten Zetten commented Feb 5, 2018 •

Copy link
Copy Markdown
Contributor

Fix for issue mentioned in #48.

I was expecting resolutions to work but it seemed that I had to fix the transitive version through the deps attribute instead. I suspect that generally it is more correct to pin all resolutions rather than just some - in the same manner as a yarn.lock file - but this at least gets the build unbroken.

@pcj

pcj commented Feb 6, 2018

Copy link
Copy Markdown
Contributor

Thanks. Yeah I think supporting yarn.lock would be the next step.

@pcj
pcj merged commit cbff612 into pubref:master Feb 6, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants