Skip to content
This repository was archived by the owner on Sep 10, 2026. It is now read-only.

fix: inner package test - #39

Merged
pcj merged 2 commits into
pubref:masterfrom
xujihui1985:master
Oct 16, 2017
Merged

pcj merged 2 commits into
pubref:masterfrom
xujihui1985:master

Conversation

@xujihui1985

Copy link
Copy Markdown
Contributor

fix mocha test when package is in the nest folder

@pcj

pcj commented Oct 13, 2017 •

Copy link
Copy Markdown
Contributor

Hi @xujihui1985 looks good, but would it be possible to include a working sample in tests/mocha_inner (or whatever you want to call it). You could probably just copy over most of tests/mocha.

@pcj

pcj commented Oct 13, 2017

Copy link
Copy Markdown
Contributor

Actually, just adding a nested BUILD file in tests/mocha with a mocha_test rule would be less clutter.

@xujihui1985

Copy link
Copy Markdown
Contributor Author

sure, I will add a test

@xujihui1985

Copy link
Copy Markdown
Contributor Author

I have added new test under mocha test

@pcj
pcj merged commit dc9f8ba into pubref:master Oct 16, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants