Repository navigation
Update example README for #111 - #126
Merged
Merged
Conversation
I was trying to modify the path that's exported and didn't realize it was _just_ changed. The documentation in the example project still reflects the old way. Gave a short example of how I did it -- I realize subclassing a protected method is dangerous but there are no other hooks. FWIW my use case was that the default regular expressions did not cover my url structure and I needed to add another one. I did not need to add more labels. Signed-off-by: Sean Walberg <sean@ertw.com>
Member
|
Hi @swalberg, Thanks for taking time to write this and send it over! I'm going to merge as is and make a couple of tweaks to caveat that extending the class isn't something we support as an API, but that it is an option. To give a bit of extra clarity on the Rack middleware situation: making it work with the the up-front label declaration left us with an API we thought was more confusing than it was worth. I am keen to come back to it into the future, but for now I'm focusing on the road to 1.0, which means focusing on more breaking changes like #107 (which I'm working on today). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I was trying to modify the path that's exported and didn't realize it was just changed. The documentation in the example project still reflects the old way.
Gave a short example of how I did it -- I realize subclassing a protected method is dangerous but there are no other hooks.
FWIW my use case was that the default regular expressions did not cover my url structure and I needed to add another one. I did not need to add more labels.