Repository navigation
Sample Values Should be Double, Not Float #2
Description
Since the original implementation of this was done in a hurry, I accidentally made the base type of metric values Float. It should be Double. This means I can drop my custom AtomicFloat implementation and switch to Google Guava's https://code.google.com/p/guava-libraries/source/browse/guava/src/com/google/common/util/concurrent/AtomicDouble.java.
/CC: @juliusv
Activity
kim commentedon Apr 4, 2013
Also, shouldn't a
Counterbe represented by aLonginstead of a floating-point number?matttproud commentedon Apr 4, 2013
I've thought about that a bit, and I can't speak to each user's potential need. Do you think it would ever be reasonable for someone to want to perform accumulation/de-accumulation operations with fractional values? Either way, on the Prometheus storage backend, it will represent these values as 64-bit. This is merely to bring coherency across the stack.
kim commentedon Apr 5, 2013
I see. A consistent (internal) representation is probably a good idea. I would just expect a
Counterto be in the domain of natural numbers.matttproud commentedon Apr 5, 2013
s/Counter/Accumulator/ ?
On Apr 5, 2013 10:43 AM, "Kim Altintop" notifications@github.com wrote:
matttproud commentedon Mar 25, 2014
This has been fixed for a long time (ca. 9 months).
attempt prometheus#2