Skip to content

Get the highest build number and use that value for latest.txt - #722

Merged
catilac merged 1 commit into
mainfrom
fix_latest_txt
Oct 5, 2026
Merged

catilac merged 1 commit into
mainfrom
fix_latest_txt

Conversation

@catilac

@catilac catilac commented Oct 5, 2026

Copy link
Copy Markdown
Contributor

Fixes #719

I used Claude to take the Issue and make a fix, and then hand checked the actual code. For now this will just take the highest build number.

The more robust fixes I think can come later, because I want to take a second to think through our system as we start to put out 5.0 beta releases, too.

Thanks for pointing this out and suggesting a fix!

Note: After merging, we'll need to re-run the build action

@catilac
catilac requested a review from SableRaf October 5, 2026 17:04
@netlify

netlify Bot commented Oct 5, 2026 •

Copy link
Copy Markdown

✅ Deploy Preview for java-processing-faf822 ready!

Name Link
🔨 Latest commit c2dde33
🔍 Latest deploy log https://app.netlify.com/projects/java-processing-faf822/deploys/6ac3d89e46ad180008a0d88a
😎 Deploy Preview https://deploy-preview-722--java-processing-faf822.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
🤖 Make changes Run an agent on this branch

To edit notification comments on pull requests, go to your Netlify project configuration.

@SableRaf

SableRaf commented Oct 5, 2026 •

Copy link
Copy Markdown
Collaborator

The more robust fixes I think can come later, because I want to take a second to think through our system as we start to put out 5.0 beta releases, too.

Yes that makes sense. I was wondering about that too. Processing 4 users should probably not get prompted for updates when a Processing 5.x version is released, at least as long as new versions of Processing 4 continue to be released in parallel.

Either way, seems like a reasonable fix for now.

@SableRaf SableRaf left a comment •

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. I didn't stare to closely at the logic, but the latest.txt in the deploy preview correctly shows 1435 as the revision number.

https://deploy-preview-722--java-processing-faf822.netlify.app/download/latest.txt

@catilac
catilac merged commit 42aca9a into main Oct 5, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

PDE update checks silently fail because /download/latest.txt returns 1.5.1 instead of a revision number

2 participants