Repository navigation
Tests are failing #123
Description
1 test failed [21:00:18]
error › invalid --config
/home/ryan/postcss-cli/test/error.js:44
43: .then(({ err, code }) => {
44: t.is(code, 1, 'expected non-zero error code')
45: t.regex(err, /ENOENT: no such file or directory/)
Actual:
0
Expected:
1
expected non-zero error code
Attn: @michael-ciniawsky
I suspect this has something to do with the latest patch version of cosmiconfig, will investigate later if no one else beats me to it.
Activity
michael-ciniawsky commentedon Apr 29, 2017
This error
/ENOENT: no such file or directory/was removed with the latest cosmiconfig updatecosmiconfig/cosmiconfig#63
cosmiconfig/cosmiconfig#64
RyanZim commentedon Apr 29, 2017
OK, thanks for doing the lookup!
It seems that we should still error out somehow if the config fails to load.
michael-ciniawsky commentedon Apr 29, 2017
Yep, but I don't now how yet tbh 😛 Now they shifted the responsibility for all their crap on us again, suckers.... 😛 I also need to add something like
resolve-fromtopostcss-load-config, because currently, if the CLI is installed globally it fails atm, (it doesn'trequire()the plugins fromprocess.cwd()) I fix it soon when time :)RyanZim commentedon Apr 29, 2017
Ugh; that's why it's good to use devDependencies + npm scripts
michael-ciniawsky commentedon Apr 29, 2017
Yep I also prefer it that way, but the fix is easy and it's nothing urgent 😛
RyanZim commentedon Feb 10, 2018
@michael-ciniawsky Is this worth fixing, or do we just remove that test and leave things as they are?