Skip to content

Drag and drop fields from one axis to another will duplicate them in React 18  #150

Closed

Description

@ianldgs
Screen.Recording.2022-06-30.at.10.02.04.mov

We are willing to send a PR to fix this, as we are heavy users of this library at IMC.
It's likely a bug with an older version of react-sortablejs or react-draggable.

Would anyone be able to review it? Haven't seen anyone responding to issues lately.

Activity

  1. bell-ho commented on Aug 22, 2022

    @bell-ho

    I have the same problem, have you solved it?

  2. ianldgs commented on Aug 22, 2022

    @ianldgs
    Author

    Yes. I rewrote the drag and drop logic with dnd-kit.

    Since I got no response about someone being able to review it, I just cloned it and published to our private npm repo.

  3. ianldgs commented on Aug 25, 2022

    @ianldgs
    Author

    @bell-ho I don't think it's rude, no. But I have to check with the legal dept of the company, don't wanna get in trouble 😄
    We also have plans to open source this kind of stuff, so I think it will be fine, but will get back to you.

  4. bell-ho commented on Sep 2, 2022

    @bell-ho

    @ianldgs Thank you for your consideration. I'll try customizing it until I get an answer.

  5. ianldgs commented on Nov 25, 2022

    @ianldgs
    Author

    I've published a package with the fixes: https://www.npmjs.com/package/@imc-trading/react-pivottable

    For now, we don't have a github repo, because it's published from our internal monorepo.
    But you can inspect the output on one of the following websites:

  6. bell-ho commented on Nov 27, 2022

    @bell-ho

    @ianldgs Thank you very much. It will be applied to the project. It's been such a big help. Thank you again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions