Skip to content

Fix bandwidth for single-value violins - #2775

Merged
etpinard merged 1 commit into
masterfrom
fixup-single-val-violin-bandwidth
Jul 5, 2018
Merged

etpinard merged 1 commit into
masterfrom
fixup-single-val-violin-bandwidth

Conversation

@etpinard

@etpinard etpinard commented Jul 4, 2018

Copy link
Copy Markdown
Contributor

bug brought up by @dmt0

cc @alexcjohnson

@etpinard etpinard added bug something broken status: reviewable labels Jul 4, 2018
@alexcjohnson

Copy link
Copy Markdown
Collaborator

If the only goal is "make it not error until there's more data" this is fine. But if we think this is a real use case we should use other violins on the same subplot to pick a bandwidth that's reasonable for the whole collection, like we do with histograms

💃 but consider making an issue for ^^

@etpinard

etpinard commented Jul 5, 2018

Copy link
Copy Markdown
Contributor Author

but consider making an issue for ^^

done in -> #2779

@etpinard
etpinard merged commit a2349ce into master Jul 5, 2018
@etpinard
etpinard deleted the fixup-single-val-violin-bandwidth branch July 5, 2018 13:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug something broken

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants