Repository navigation
Replace country-regex Part 2 #7026
Description
Plotly.js still contains country-regex as a dependency. I'll just cite @keithrob from his original PR:
"The NPM package that is currently used by plotly, country-regex, is a very good package for taking common country names and correlating them to their ISO3 codes. However, it used a GPLed regex library from the R package countrycode. It is questionable whether country-regex can be a MIT license when it is a direct descendent of R version."
I'm not sure about the MIT license, but every project that uses plotly.js might be a derived work of this original GPL licensed project and therefore subject to its copyleft restrictions. This might light up in your deep inspecting license compliance tool and might make your lawyer sweaty.
see #3944
see keithrob#1
Activity
gvwilson commentedon Jul 20, 2024
hi @archmoj - can you please let me know if you want to factor this into ongoing map changes or push to the next cycle? I'm happy either way.
dimitrov570 commentedon Oct 8, 2024
Hi,
What is the status of this issue? Could you please provide an update on when this is planned to be resolved? It is currently being detected by license compliance inspecting tools.
Thank you!
gvwilson commentedon Oct 8, 2024
It is currently in our backlog but won't be in the major release later this month unless someone from the community does a PR in the next few days. We can try to get it into the next minor release, but again, a community PR would greatly increase the chances of that happening. Thanks - @gvwilson
dimitrov570 commentedon Dec 12, 2024
I would like to contribute. Is using i18n-iso-countries satisfactory solution for your requirements (as it's done here keithrob#1)?
gvwilson commentedon Dec 12, 2024
Thanks @dimitrov570 - yes, we'd be very grateful for a PR, and the package you mention looks like a good starting point - thank you.