npm run citest-jasmine fails locally #666

Activity

1. etpinard

   added

   type: maintenance

   status: discussion needed

   on Jun 20, 2016
2. alexcjohnson commented on Jun 20, 2016

   

   alexcjohnson

   on Jun 20, 2016

   Collaborator

   More actions

   Locally I see a default body margin of 8px. I'd rather just set this to 0, then the pixel positions we have to use for mouse events will make more sense anyway. I'll try to address this in my working branch.

   👍React with 👍1Reacted by etpinard
3. alexcjohnson

   added a commit that references this issue on Jun 21, 2016

   lock test graphDiv to position 0,0 and other jasmine reliability tweaks

   ...

   This issue will close once commit dddb6e1 is merged into the 'main' branch.

   dddb6e1
4. alexcjohnson

   closed this as completedin dddb6e1on Jun 22, 2016
5. etpinard

   reopened this on Jun 23, 2016
6. etpinard commented on Jun 23, 2016

   

   etpinard

   on Jun 23, 2016

   Last edited by etpinard

   ContributorAuthor

   More actions

   @rreusser off v1.14.0:

   Firefox 42.0.0 (Mac OS X 10.11.0) mapbox plots should be able to relayout FAILED
       Expected 80,100,904,270 to be close to 80,100,908,270.
   

   and

   Firefox 42.0.0 (Mac OS X 10.11.0) hover on fill should always show one label in the right place FAILED
       Expected 254.27499999999998 to be close to 249.175, -1, 'trace 2:x'.
       assertLabelsCorrect/</<@/var/folders/5s/mm8_jrls0zd34zkb1z71xb940000gp/T/3e5f6eaff748734ec0be007b7921fd04.browserify:152118:17 <- tests/hover_label_test.js:673:0
   
7. rreusser commented on Jun 23, 2016

   

   rreusser

   on Jun 23, 2016

   Last edited by rreusser

   Contributor

   More actions

   Failed tests:

   • tests/hover_label_test.js:673:0
   • tests/mapbox_test.js:361:0

   Commit: b6fc59d
8. etpinard

   closed this as completedin #1211on Dec 1, 2016