Skip to content

Remove Math.sign #1773

Closed
Closed
Remove Math.sign#1773
Assignees
alexcjohnson
Labels
bugsomething broken

Description

@alexcjohnson
alexcjohnson
opened on Jun 9, 2017

Math.sign is not supported in IE, even IE11. Currently we only seem to have this in gl2d/camera
https://github.com/plotly/plotly.js/blob/master/src/plots/gl2d/camera.js#L134
https://github.com/plotly/plotly.js/blob/master/src/plots/gl2d/camera.js#L152

We should remove these and include Math.sign (any other IE quirks?) in our syntax tests.

Activity

  1. alexcjohnson
    added
    bugsomething broken
    on Jun 9, 2017
  2. alexcjohnson
    self-assigned this
    on Jun 16, 2017

  3. alexcjohnson commented on Jun 19, 2017

    @alexcjohnson
    alexcjohnson
    on Jun 19, 2017
    CollaboratorAuthor

    fixed by #1792

  4. alexcjohnson
    closed this as completedon Jun 19, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

bugsomething broken

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions