in version 1.4 onclick event broken #173

Activity

1. etpinard commented on Jan 11, 2016

   

   etpinard

   on Jan 11, 2016

   Contributor

   More actions

   Bug confirmed (for all traces but pies, it looks like). Working on a fix now.
2. etpinard

   added

   bugsomething brokensomething broken

   on Jan 11, 2016
3. etpinard commented on Jan 11, 2016

   

   etpinard

   on Jan 11, 2016

   Contributor

   More actions

   Click events are working in v1.3.1 http://cdn.plot.ly/plotly-1.3.1.min.js
4. etpinard commented on Jan 11, 2016

   

   etpinard

   on Jan 11, 2016

   Contributor

   More actions

   @alexcjohnson commenting out fx.unhover in the dragBox definition makes click events work again.

   Why did you put this in b1a1c24 ?
5. etpinard commented on Jan 11, 2016

   

   etpinard

   on Jan 11, 2016

   Contributor

   More actions

   Right. We need to clear the hover labels when starting a selection. Let's see if there's a way to make that happen on click events.
6. alexcjohnson commented on Jan 11, 2016

   

   alexcjohnson

   on Jan 11, 2016

   Collaborator

   More actions

   Ah, nuts.

   Right. We need to clear the hover labels when starting a selection.

   bingo. It's nice there because that clears hover labels on ANY drag event... select, zoom, pan... but I guess the solution would be to wait until dragged is true (which gets plugged into gd._dragged, though at this point that's only used within the fx.dragElement closure so could and should be ditched in favor of a local var). I suppose either we could say hover effects should always clear when you're dragging, no matter what it is you're dragging... then we could put the fx.unhover call right there in fx.dragElement next to gd._dragged = true;. If you don't feel comfortable with that in all cases, we could add an options.draggedFn (these should really be called options.onDragged etc shouldn't they...) to be called there.
7. etpinard commented on Jan 11, 2016

   

   etpinard

   on Jan 11, 2016

   Contributor

   More actions

   I suppose either we could say hover effects should always clear when you're dragging, no matter what it is you're dragging...

   @alexcjohnson Could you give me examples of things that can be dragged ?
8. alexcjohnson commented on Jan 11, 2016

   

   alexcjohnson

   on Jan 11, 2016

   Collaborator

   More actions

   dhcp159:plotlyjs alex$ ag dragElement
   src/components/annotations/index.js
   586:                Plotly.Fx.dragElement({
   644:            Plotly.Fx.dragElement({
   
   src/components/colorbar/draw.js
   458:            Plotly.Fx.dragElement({
   
   src/components/legend/index.js
   531:        Plotly.Fx.dragElement({
   
   src/plots/cartesian/graph_interact.js
   1412:    fx.dragElement(dragOptions);
   1992:fx.dragElement = function(options) {
   
9. alexcjohnson commented on Jan 11, 2016

   

   alexcjohnson

   on Jan 11, 2016

   Collaborator

   More actions

   I think this is OK - fx.unhover works fine when there's no hover to begin with, and in all of those cases if for whatever reason there DID happen to be some hovertext that didn't get cleared, it would be nice to do so!
10. alexcjohnson

    added a commit that references this issue on Jan 11, 2016

    move fx.unhover call to onMove handler

    026e16e
11. etpinard commented on Jan 11, 2016

    

    etpinard

    on Jan 11, 2016

    Contributor

    More actions

    @alexcjohnson thanks.

    I'd vote for clearing all hover effects upon dragged. I don't see the need to add logic for annotations, legend and colorbar dragging - at least for now.
12. etpinard

    closed this as completedin b80de2eon Jan 11, 2016