Repository navigation
scattergeo does not respect datum position in arrayOk attributes #1529
Description
For example
Plotly.plot('graph', [{
type: 'scattergeo',
lon: [10, null, 40],
lat: [0, null, 0],
marker: {
color: ['red', 'green', 'blue'],
size: [20, 50, 10]
}
}])yields
see http://codepen.io/etpinard/pen/QpJGeq
This issues comes from #1004 where we started skipping over items with non-numeric lon and/or lat coordinates.
Post #1519 (comment), I'm having second thoughts about skipping non-numeric items in the calc step though mapbox/calc.js appears to get this right. Ignoring non-numeric items early makes sense for 🐎 as we save a few isNumeric call in hot code paths (e.g. in <>/plot.js), but it does lead to some headaches elsewhere in the code (e.g. those placeholder flags) 😕
Activity
[-]scattergeo does not datum position in arrayOk attributes[/-][+]scattergeo does not respect datum position in arrayOk attributes[/+]alexcjohnson commentedon Mar 30, 2017
if
isNumericis a concern (I'm not sure it is compared to everything else that needs to happen in<>/plot.js, but it wouldn't hurt to optimize this) we should be able to ensure<>/calc.jsreplaces all non-numeric points withBADNUMand just use!== BADNUMwhich is about as fast as can be imagined.Right now scatter uses
falsefor non-numerics but that was an ancient decision... if we standardize on something it should beBADNUM.