Skip to content

Bug fix for subplot() #266

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cpsievert merged 1 commit into from
Aug 14, 2015
Merged

Bug fix for subplot() #266

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions R/subplots.R
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,12 +75,13 @@ subplot <- function(..., nrows = 1, which_layout = "merge", margin = 0.02) {
# bump x/y axis anchors appropriately
p_info$xaxis <- sub("x1", "x", paste0("x", p_info$key))
p_info$yaxis <- sub("y1", "y", paste0("y", p_info$key))

# Only do domain computations if they are _completely_ missing
# (I don't think it makes sense to support partial specification of domains)
if (all(is.na(with(p_info, c(xstart, xend, ystart, yend))))) {
p_info[c("xstart", "xend", "yend", "ystart")] <-
get_domains(max(p_info$key), nrows, margin)
doms <- get_domains(max(p_info$key), nrows, margin)
doms$plot <- as.character(seq_len(nrow(doms)))
p_info <- p_info[!names(p_info) %in% c("xstart", "xend", "ystart", "yend")]
p_info <- plyr::join(p_info, doms, by = "plot")
}
# empty plot container that we'll fill up with new info
p <- list(
Expand Down