Repository navigation
Conversation
|
Thanks @rpkyle! Are you able to run |
Yeah, I think I see the same -- comparing with TravisCI's
... I have
Let me know if there's anything else I can do on my end. Output of
|
|
Ok, yea, I'll give it a quick look, but to be honest that test is so brittle I'm questioning whether it's worth keeping at this point. Would you mind also adding a couple |
|
@cpsievert Sure thing, I'll try to make a summary checklist of tests here, once posted just let me know if I've missed anything and I'll add it in. |
|
@cpsievert Apologies for letting this PR stale for a bit, should be able to return to this once tomorrow or the day after once my task list has reduced by a few items. |
|
I'm still very much looking forward to seeing this PR land sometime soon! I think @rpkyle might be a bit overwhelmed with other work so if you have a sec @cpsievert we'd love an assist... Plotly.js is up to 1.51.3 now and has yet another new trace type :) 1.52 is around the corner in early January and will feature... legend titles! |
|
FYI 1.51 contains some fixes for |
|
Is there an ETA for the 1.52 release? |
|
First couple weeks of January |
|
Hey @cpsievert ! Happy new year :) Plotly.js 1.52.0 is out now, with the full set of fixes for Sunburst & Treemap, and a bunch of other goodies like legend titles, choropleth GeoJSON support, and legend items for choropleth, so we can finally do categorical choropleths with arbitrary data :) |
|
I'll be starting a new PR soon for upgrading to 1.52 |
|
Thanks @cpsievert! I've been meaning to ask about this. I just updated to 1.52 in my fork to get around a couple issues. That worked fine on my end, although I haven't done any of the supporting tasks like updating tests. FWIW, that is here: https://github.com/bhogan-mitre/plotly Please keep us posted, and let us know if there are pieces you could use help with along the way. |
This PR proposes to update
plotly.jsto v1.50.1, released on 2019-10-15, using the zipfile available at https://api.github.com/repos/plotly/plotly.js/releases/20719620.The schema has been regenerated using
plotlyjs.R.shinytestbaselines were updated, and visual baselines were also updated as suggested here.Output when regenerating visual baselines