[RaphaelFakhri]

Summary

When path is an existing directory whose name has a dot, such as reports/2024.01.31, coerce_for_js takes the part after the last dot as the image format. The render fails with ValueError: Invalid format '31' and no file is written. With the default cancel_on_error=False the error is only returned, so the call looks like it succeeds. A directory named plots.svg silently switches the output to SVG.

determine_path already treats such a path as a directory. This change makes coerce_for_js agree with it: only a file path's suffix sets the format, and a directory falls back to the format option or the default png.

Fixes #483

Changes

• kaleido/_utils/fig_tools.py: skip path.suffix when path is a directory.
• tests/test_fig_tools.py: add test_coerce_for_js_directory_with_suffix for 2024.01.31 and plots.svg, passed as Path and str.
• CHANGELOG.md: add an entry under Unreleased.

Testing

• uv run pytest tests/test_fig_tools.py -k directory_with_suffix: 2 failed before the change (ValueError: Invalid format '31', assert 'svg' == 'png'), 2 passed after.
• uv run pytest tests/test_fig_tools.py tests/test_path_tools.py: 276 passed.
• End to end with Chrome, kaleido.write_fig_sync(fig, path=<dir>/2024.01.31) returned the ValueError and wrote nothing before, and writes Sales.png after.
• ruff check . passes.