Skip to content
This repository was archived by the owner on Aug 29, 2025. It is now read-only.
This repository was archived by the owner on Aug 29, 2025. It is now read-only.

Schedule Tab UI QA roundup #499

Closed
Closed

Description

@nicolaskruchten

Let's gather up a few problems here for fixup in a smaller number of PRs than 1-1...

Activity

  1. nicolaskruchten commented on Jul 24, 2018

    @nicolaskruchten
    ContributorAuthor

    After creating a query, the "Query name" is still editable...

    image

  2. nicolaskruchten commented on Jul 24, 2018

    @nicolaskruchten
    ContributorAuthor

    If I log out of Plotly (or boot Falcon without logging in) and then write a nice fancy query and then hit "schedule" and go through the login process as prompted, I lose my query, it disappears from the query box so I can't schedule it.

  3. nicolaskruchten commented on Jul 24, 2018

    @nicolaskruchten
    ContributorAuthor

    If I boot Falcon and I have some queries scheduled but I'm not logged in, I have no indication that these queries aren't going to successfully run unless I do log in.

    Per @n-riesco this isn't the case, I had incorrectly assumed it was based on the logged-in/not-logged-in UI. I'm still not sure what is and isn't possible when "not logged in" and why :)

  4. mfix22 commented on Jul 24, 2018

    @mfix22
    Contributor

    If I log out of Plotly (or boot Falcon without logging in) and then write a nice fancy query and then hit "schedule" and go through the login process as prompted, I lose my query, it disappears from the query box so I can't schedule it.

    Currently when you log in, the entire app is refreshed which makes it non-trivial to persist the query string.

    Perhaps instead we disable the schedule button and warn about query loss in a tooltip?

  5. nicolaskruchten commented on Jul 25, 2018

    @nicolaskruchten
    ContributorAuthor

    This one isn't strictly related to the scheduling stuff, but will resolve #479 and I can't seem to do it in my dev environment due to build errors: I'd like to bump the react-chart-editor dependency from 0.18 to 0.21 please :)

  6. briandennis commented on Jul 25, 2018

    @briandennis
    Contributor

    @nicolaskruchten was your build error similar to the one on CI? I can't replicate this locally when building...

  7. nicolaskruchten commented on Jul 26, 2018

    @nicolaskruchten
    ContributorAuthor

    Nope, I'm having issues building the Oracle driver from source.

  8. nicolaskruchten commented on Jul 26, 2018

    @nicolaskruchten
    ContributorAuthor

    From my POV things are looking good here... It'd be great if we could wrap and merge #500 today and then cut a release tomorrow :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions