MSSQL: Database table overview wrong #462

Activity

1. n-riesco

   added

   bug

   on Jun 22, 2018
2. n-riesco

   changed the title [-]Database table overview wrong[/-] [+]MSSQL: Database table overview wrong[/+] on Jun 22, 2018
3. n-riesco commented on Jun 22, 2018

   

   n-riesco

   on Jun 22, 2018

   Last edited by n-riesco

   Contributor

   More actions

   Please, could you check what errors are reported in the log file %USERPROFILE%\.plotly\connector\log.log?

   In particular, I'm interested in errors with the responses to sql-tables and sql-schemas.
4. n-riesco commented on Jun 22, 2018

   

   n-riesco

   on Jun 22, 2018

   Last edited by n-riesco

   Contributor

   More actions

   Oh! it looks like when we get the tables schemas we don't filter by database name.

   Currently, we are using this query to build the overview:

                   SELECT T.name AS Table_Name, C.name AS Column_Name, P.name AS Data_Type
                   FROM sys.objects AS T
                      JOIN sys.columns AS C ON T.object_id = C.object_id
                      JOIN sys.types AS P ON C.system_type_id = P.system_type_id
                   WHERE T.type_desc = 'USER_TABLE';

   After some experimentation, this query works for me:

   SELECT table_name, column_name, data_type
   FROM information_schema.columns
   WHERE table_catalog = '${database}'
   ORDER BY table_name

   @pabucur please, could you check whether the above query works for you? You need to replace ${database} by your database name.
5. n-riesco

   self-assigned this

   on Jun 22, 2018
7. n-riesco

   added 2 commits that reference this issue on Jun 22, 2018

   mssql: get schemas for current database only

   ...

   This issue will close once commit a8208b2 is merged into the 'beeline' branch.

   a8208b2

   mssql: quote database, schema and table names

   ...

   This issue will close once commit a9bebda is merged into the 'beeline' branch.

   a9bebda
8. n-riesco

   closed this as completedin a9bebdaon Jun 25, 2018
9. n-riesco

   added a commit that references this issue on Jun 25, 2018

   Merge pull request #464

   ...

   f54de61