Skip to content

Remove references to welcome_page() and htmlDiv() from dash.R and utils.R #78

Closed

Description

@rpkyle

The DashR package should be standalone, in that it has no dependencies on component libraries.

Currently, DashR retains references to welcome_page() and htmlDiv(), though these should be removed.

Activity

  1. self-assigned this
    on Apr 1, 2019
  2. rpkyle commented on Sep 5, 2019

    @rpkyle
    ContributorAuthor

    welcome_page was eliminated when #99 was merged. htmlDiv persists:

    dashR/R/dash.R

    Line 605 in 780fb64

    layout_ <- dashHtmlComponents::htmlDiv(children = layout_, id = layout_container_id())

    A small PR will be opened to address this item, then will close this issue when merged.

  3. rpkyle commented on Jun 3, 2020

    @rpkyle
    ContributorAuthor

    The call to htmlDiv was eliminated by #121. Closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions