Repository navigation
Clientside prevent update - #964
Conversation
|
Thanks @jjaraalm - looks fantastic. Very nice tests, very clean implementation. To get the linter to pass, just |
|
Thanks! It's all good, one day I hope to make my linters happy without effort ... one day ... maybe |
|
Alright, looks great! This definitely merits an entry in the changelog, then it'll be ready to go. We'll hold off merging for a couple of days though, as we're planning a patch release 1.4.1 and this has new features so needs to go in a minor (1.5.0) |
|
This is great 🎉 |
|
Thanks @chriddyp ! @alexcjohnson should I update the changelog or will you all do it? |
|
@jjaraalm go for it! Just add at the top, and try to format the entry like the ones below it. |
|
|
||
| if namespace in ['PreventUpdate', 'no_update']: | ||
| raise ValueError('"{}" is a forbidden namespace in' | ||
| ' dash_clientside.'.format(namespace)) |
There was a problem hiding this comment.
FYI @rpkyle - I think this namespace exclusion is the only piece of this PR that's relevant to R
alexcjohnson
left a comment
There was a problem hiding this comment.
💃 Beautiful, very nicely done!
…ash-4.17.21 Bump lodash from 4.17.19 to 4.17.21
…17.21 Bump lodash from 4.17.19 to 4.17.21
Adds
dash_clientside.no_updateanddash_clientside.PreventUpdateto fix #963. Integration tests added and passing.Also changed a
Popencall in_utils.pyso that the path is properly searched on windows machines. Otherwise, building was failing for me. Feel free to remove if you think it's not necessary.Contributor Checklist
optionals
CHANGELOG.md