Repository navigation
Remote grid - #894
Merged
Merged
Remote grid#894
Conversation
added 4 commits
August 27, 2019 13:43
alexcjohnson
approved these changes
Aug 31, 2019
alexcjohnson
left a comment
alexcjohnson
left a comment
Collaborator
There was a problem hiding this comment.
💃 at some point it may be nice to include a test for this feature, but if that's going to be a major effort, I won't hold this up for it right now.
Contributor
Author
|
I will probably add few unit tests |
add unit tests for simple argument checks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This closes #829
added a new argument
--remote-urlfor the usage of selenium grid in the cloud, to test with a local host grid, users just need to add--remote