proposal. Set serve_locally = True by default #284

Activity

1. valentijnnieman commented on Jul 10, 2018

   

   valentijnnieman

   on Jul 10, 2018

   Contributor

   More actions

   I don't see why not! 👍
2. nicolaskruchten commented on Jul 10, 2018

   

   nicolaskruchten

   on Jul 10, 2018

   Contributor

   More actions

   Yes, yes, yes! The slight performance boost from the CDN is probably not worth the headache and perception of requiring outbound connections.
3. chriddyp commented on Jul 10, 2018

   

   chriddyp

   on Jul 10, 2018

   Member

   More actions

   I think I'm 👍 with this as well.

   A few notes for discussion:

   • Some users have had issues with serve_locally: Serving large files locally (JS bundles) on windows machines in flask sometimes doesn't work #56
   • The unpkg cdn hasn't always been reliable. There's been 3 times in the last year where it hasn't served things correctly: Error loading react-dom@15.4.2 #114, Missed react-dom.min.js (react-dom@15.6.1) unpkg/unpkg#54
   • Would switching this break anyone's code? There is some weird logic where if serve_locally = True then any scripts or stylesheets appended with an external_url won't work (the original idea being that there would be two versions of each resource supplied, one local and one external, and you could swap between the two. That's how the component library's stylsheets and scripts are included. However, in practice, we end up just doing app.scripts.append_script({'external_url': ...})). So, we would have to remove that logic in a way that doesn't end up including the component's resources twice. All of that stuff should be reworked anyway.
4. nicolaskruchten commented on Jul 10, 2018

   

   nicolaskruchten

   on Jul 10, 2018

   Contributor

   More actions

   IIRC there was some issue with serving up your own CSS as well as serving locally, or something like that. Worth making sure that #265 is compatible with serve_locally=True without any downsides
5. T4rk1n commented on Jul 10, 2018

   

   T4rk1n

   on Jul 10, 2018

   Contributor

   More actions

   I think it should be set to True if debug = True, what I have for the static files is compatible with the serve_locally option.

   👍React with 👍1Reacted by Ben Postlethwaite
6. ned2 commented on Jul 11, 2018

   

   ned2

   on Jul 11, 2018 via email

   Contributor

   More actions

   If we can smooth over the transition issues then I think serve_locally = True by default would make a lot of sense. We should aim for a default path of least friction, which I think this is.

   …

   On Wed, 11 Jul 2018 at 00:28, Philippe Duval ***@***.***> wrote: I think it should be set to True if debug = True, what I have for the static files is compatible with the serve_locally option. — You are receiving this because you are on a team that was mentioned. Reply to this email directly, view it on GitHub <#284 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ACs1GNuCxYee2JQp25QI274scxq3Hp1Xks5uFLofgaJpZM4VJVbW> .

   -- nedned.net
7. alexcjohnson

   closed this as completedin #722on May 21, 2019
8. AnnMarieW

   added a commit that references this issue on Jan 6, 2022

   Merge pull request plotly#284 from plotly/282-tabs-content-fix

   ...

   96b5f67