Repository navigation
requests for missing favicon.ico cause dash's index route to be served #152
Description
I just noticed that when a favicon is not wired up, the automatic request for /favicon.ico by the browser results in the dash server returning its index route. This seems to be a consequence of there being a catchall redirecting all URLs that are not matched to the index route.
While probably not too harmful, this seems undesirable. One solution could be to include a default favicon, but perhaps it is also worth establishing whether the catchall behaviour is desirable?
Metadata
Metadata
Assignees
Labels
No labels
Activity
[-]failed requests for favicon cause dash's index route to be served[/-][+]requests for missing favicon.ico cause dash's index route to be served[/+]rmarren1 commentedon Sep 25, 2018
I like the idea of having a default favicon, maybe the Dash logo? Or we can just add a default route for
favicon.icoin Dash that returns nothing when there is nofavicon.icoin the assets directorychriddyp commentedon Sep 25, 2018
Yeah, I like the idea of a built-in Dash favicon too.
T4rk1n commentedon Sep 25, 2018
I think including a default dash
favicon.icois better than a 404.chriddyp commentedon Sep 25, 2018
Here are some favicons we could use
dash-favicons.zip
T4rk1n commentedon Sep 26, 2018
I will add the
favicon.icoin the zip as the default favicon.Merge pull request #152 from plotly/chriddyp-dev-tools
Merge pull request plotly#152 from plotly/update-plotly-url
Merge pull request #152 from plotly/update-plotly-url