Deploy dash* wheels to PyPI on releases #1440

Activity

1. silverguo commented on Nov 2, 2020

   

   silverguo

   on Nov 2, 2020

   Last edited by silverguo

   More actions

   Definitely looking forward to have the wheels uploaded to pip for dash.

   Happy to help if needed.
2. anders-kiaer commented on Apr 13, 2021

   

   anders-kiaer

   on Apr 13, 2021

   ContributorAuthor

   More actions

   Bumping this issue with some additional context/input, as I think this is an easy low hanging fruit to further improve dash user experience 🚀

   In order to see how much faster installation is when a wheel is available compared to only sdist/tar.gz, I tested pip installing a wheel and sdist build of dash, respectively, using the current dev branch. On my machine I saw a 50% reduction in dash installation time (and I expect ~similar installation time improvements for the dependencies dash-core-components, dash-html-components, dash-table etc.)

   Having a wheel available on PyPI also avoids some users getting an error during installation of the form (which pip recovers from by falling back to source installation, but still can confuse users):

   pip install dash
   ...
   Building wheels for collected packages: dash
     Building wheel for dash (setup.py) ... error
     ERROR: Command errored out with exit status 1:
      command: /home/[...]/bin/python -u -c 'import sys, setuptools, tokenize; sys.argv[0] = '"'"'/tmp/pip-req-build-jifoji898/setup.py'"'"'; __file__='"'"'/tmp/pip-req-build-jifoji898/setup.py'"'"';f=getattr(tokenize, '"'"'open'"'"', open)(__file__);code=f.read().replace('"'"'\r\n'"'"', '"'"'\n'"'"');f.close();exec(compile(code, __file__, '"'"'exec'"'"'))' bdist_wheel -d /tmp/pip-wheel-89ud89a
          cwd: /tmp/pip-req-build-jifoji898/
     Complete output (6 lines):
     usage: setup.py [global_opts] cmd1 [cmd1_opts] [cmd2 [cmd2_opts] ...]
        or: setup.py --help [cmd1 cmd2 ...]
        or: setup.py --help-commands
        or: setup.py cmd --help
     
     error: invalid command 'bdist_wheel'
     ----------------------------------------
     ERROR: Failed building wheel for dash
     Running setup.py clean for dash
   Failed to build dash
   Installing collected packages: dash
       Running setup.py install for dash ... done
   Successfully installed dash-1.20.0
   ...
   

   You also reduce the risk of different installation errors. An example is the one black has experienced lately (black is one of the few top 360 Python packages not currently having a wheel), where one of the pip maintainers give a general reminder that also Python projects (without e.g. C-code to compile) should have wheels available, which is pip's preferred/default format to download and install: psf/black#1847 (comment).

   ---

   I don't know your release procedure (manual/automatic), but appending bdist_wheel --universal to the python setup.py sdist command (and potentially a pip install wheel prior to that command on the build computer/node) should be ~enough.

   Are the artifacts after commands with sdist in the CI like here

   dash/.circleci/config.yml

   Line 124 in 597dc22

   cd dash-renderer && renderer build && python setup.py sdist && mv dist/* ../packages/ && cd ..

   used in the release procedure? If so I can create a PR. Or is the release procedure defined outside the repo? (cc @harryturr - last release manager).

   Thanks 🙂
3. anders-kiaer commented on Mar 3, 2022

   

   anders-kiaer

   on Mar 3, 2022

   ContributorAuthor

   More actions

   Starting with version 2.0, the PyPI release of dash now has wheels:
   https://pypi.org/project/dash/2.0.0/#files

   🎉
4. anders-kiaer

   closed this as completedon Mar 3, 2022