Dash.jl package generator does not appear to support different folder structures for dependencies

As originally described in #1125, some component library authors may store their components in a location other than the one we're used to seeing. For dash-bootstrap-components, the JS bundle is actually stored within a _components subdirectory.

The lines in the Julia component generator which copy in the CSS & JS dependencies date from the initial version I wrote, before the changes in #1125 were added:

dash/dash/development/_jl_components_generation.py

Lines 519 to 528 in 938c3ca

    
           os.makedirs("deps") 
        
           for javascript in glob.glob("{}/*.js".format(project_shortname)): 
        
               shutil.copy(javascript, "deps/") 
        
           for css in glob.glob("{}/*.css".format(project_shortname)): 
        
               shutil.copy(css, "deps/") 
        
           for sourcemap in glob.glob("{}/*.map".format(project_shortname)): 
        
               shutil.copy(sourcemap, "deps/")

I suggest updating the component generator to support different folder structures for Dash.jl libraries as well.

@gvwilson

Hi - we are tidying up stale issues and PRs in Plotly's public repositories so that we can focus on things that are most important to our community. If this issue is still a concern, please add a comment letting us know what recent version of our software you've checked it with so that I can reopen it and add it to our backlog. (Please note that we will give priority to reports that include a short reproducible example.) If you'd like to submit a PR, we'd be happy to prioritize a review, and if it's a request for tech support, please post in our community forum. Thank you - @gvwilson

Navigation Menu

Repository navigation

Dash.jl package generator does not appear to support different folder structures for dependencies #1435

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

	os.makedirs("deps")

	for javascript in glob.glob("{}/*.js".format(project_shortname)):
	shutil.copy(javascript, "deps/")

	for css in glob.glob("{}/*.css".format(project_shortname)):
	shutil.copy(css, "deps/")

	for sourcemap in glob.glob("{}/*.map".format(project_shortname)):
	shutil.copy(sourcemap, "deps/")

Dash.jl package generator does not appear to support different folder structures for dependencies #1435

Description

Activity

gvwilson commented on Jul 18, 2024

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions