Skip to content

Remove CSRF protection #141

Closed
Closed

Description

@chriddyp

Besides the GET of index.html, Dash only supports POST requests with application/json. These are actually unsusceptible to CSRF attacks according to https://security.stackexchange.com/questions/23371/csrf-protection-with-custom-headers-and-without-validating-token/58308#58308. Based off of this, I believe that we should be able to remove CSRF protection and therefore will not require users to create a app.server.config.SECRET_KEY.

Activity

  1. ned2 commented on Oct 14, 2017

    @ned2
    Contributor

    I don't know enough about CSRF to comment on whether that makes sense, but if that's the case, then yeah I definitely reckon it should go. It caused me a lot of hassles working out that I needed to set the secret key, and it's something I've seen coming up a fair bit as an issue for people on the community forums. Would save a bit of headache potentially.

  2. added 2 commits that reference this issue on Oct 17, 2017
    b67fb98
    6227591
  3. added a commit that references this issue on Oct 17, 2017
    5e03e94
  4. added a commit that references this issue on Apr 23, 2019
  5. added a commit that references this issue on May 28, 2021
  6. added a commit that references this issue on Jul 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions