Skip to content
This repository was archived by the owner on Aug 29, 2025. It is now read-only.

updating react and react-dom to 15.6.1 - #12

Closed
ned2 wants to merge 1 commit into
plotly:masterfrom
ned2:update-react-15.6.1
Closed

ned2 wants to merge 1 commit into
plotly:masterfrom
ned2:update-react-15.6.1

Conversation

@ned2

@ned2 ned2 commented Aug 16, 2017

Copy link
Copy Markdown

react-dom 15.4.2 seems to have disappeared from unpkg, so have upgraded external and local to 15.6.1

not sure if this is actually helpful but having got it all working on my dev environment with 15.6.1, figured I'd submit a PR

@ned2

ned2 commented Aug 16, 2017

Copy link
Copy Markdown
Author

it's about now I guess I should probably work out how to run the tests...

@ned2

ned2 commented Aug 16, 2017

Copy link
Copy Markdown
Author

Oh I see that the tests have v15.4.2 hardcoded... I guess that's the likely culprit

@chriddyp

Copy link
Copy Markdown
Member

Thanks @ned2 ! It seems like this issue was temporary from unpkg: unpkg/unpkg#54 and that it is resolved. I don't think that changing the version will help us in the future here.
I've seen 2 issues since launch with Unpkg so I might consider loading these resources from a different CDN.

@chriddyp chriddyp closed this Aug 16, 2017
@ned2
ned2 deleted the update-react-15.6.1 branch December 28, 2017 11:41
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants