Skip to content
This repository was archived by the owner on Aug 29, 2025. It is now read-only.
This repository was archived by the owner on Aug 29, 2025. It is now read-only.

Boolean attributes in button: disabled #32

Open

Description

@Akronix

Hello.

I'm trying to use the disabled attribute in the button element.

Firstly, I've noticed that its type is String instead of Boolean.
Secondly, I've trying to set the prop disabled='disabled', but it does not work; and it is still enabled.

Other props of button with expected similar behaviour (boolean props) are: autoFocus, contentEditable, draggable, hidden, spellCheck, etc.

Activity

  1. Akronix commented on Jan 29, 2018

    @Akronix
    ContributorAuthor

    I finally got it done using the disabled attribute with a string as it is currently in the upstream repo.

    Nevertheless, I was taking a look on how to change the PropTypes of html attributes, but I didn't find the way to do it. I guess that changing it directly in Button.react.js isn't the right way.

  2. radekwlsk commented on Jul 18, 2018

    @radekwlsk

    Have you tried setting it to simply True? I am doing that with html.Button for a long time and never had an issue with html.Button("I am a disabled button", disabled=True).

  3. Akronix commented on Jul 23, 2018

    @Akronix
    ContributorAuthor

    Hmm I just checked and it does work! But the prop for disabled in the component is still Boolean 🤔

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions