Skip to content

Issues #131 and #162 resolved - #167

Merged
alexcjohnson merged 1 commit into
plotly:masterfrom
MrTeale:fix/131-imports
Apr 6, 2022
Merged

alexcjohnson merged 1 commit into
plotly:masterfrom
MrTeale:fix/131-imports

Conversation

@MrTeale

@MrTeale MrTeale commented Mar 30, 2022

Copy link
Copy Markdown
  1. Issue use _imports_ not load_components #131: removed _dash.development.component_loader.load_components and utilised ._imports_ as seen in dash-bio

  2. Issue Next release/best way of using last version #162: ._imports_ fix from use _imports_ not load_components #131 allows for installs via:

pip install git+https://github.com/plotly/dash-daq.git#egg=dash_daq
# or until merged, use:
pip install git+https://github.com/mrteale/dash-daq.git@fix/131-imports#egg=dash_daq

@MrTeale

MrTeale commented Mar 30, 2022

Copy link
Copy Markdown
Author

Fixes #69

@alexcjohnson alexcjohnson left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💃 Thanks @MrTeale - I didn't realize dash-daq was still using the old load_components, definitely time to upgrade!

Merging now, unfortunately it still may be a little while before we're able to release this as there are a whole bunch of changes made in the fall and winter that we haven't had a chance to QA. We'll try to get to it soon but I can't say when.

@alexcjohnson
alexcjohnson merged commit f543235 into plotly:master Apr 6, 2022
@MrTeale
MrTeale deleted the fix/131-imports branch April 6, 2022 13:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants