Skip to content

Visual bugs found in DDK Docs for DAQ #153

Open

Description

@luiztauffer

Some visual bugs that should still be fixed (@vinicvaz)

  • Boolean switch vertical overlaps with label:
    image

  • Slider bar transparent (both light/dark modes):
    image

  • LED Display background for Dark mode:
    image

Activity

  1. added a commit that references this issue on Sep 26, 2021
  2. Karan-S-Mittal commented on Sep 29, 2021

    @Karan-S-Mittal
    Contributor

    Solution Preview:

    issue 153

    Code:

    app.layout = html.Div(
        [
                html.Div(
                    [html.H2("Switch Issue 153", className="text-center")], className="row"
                ),
                html.Div(
                    daq.BooleanSwitch(
                        id="my-switch-1", on=True, label="Vertical", vertical=True
                    ),
                    className="row",
                ),
                html.Div(
                    [html.H2("Slider Issue 153", className="text-center")], className="row"
                ),
                html.Div(daq.Slider(vertical=True), className="row"),
                html.Div(
                    [html.H2("Slider Issue Dark mode 153", className="text-center")],
                    className="row",
                ),
                html.Div(
                    daq.DarkThemeProvider(daq.Slider(vertical=True), theme={"dark": True}),
                    className="row",
                ),
                html.Div(
                    [
                        html.H2(
                            "LED Display Backgroun for darkmode Issue 153",
                            className="text-center",
                        )
                    ],
                    className="row",
                ),
                html.Div(
                    daq.DarkThemeProvider(
                        daq.LEDDisplay(
                            value="3.14159",
                        ),
                        theme={"dark": True},
                    ),
                    className="row",
                ),
        ]
    )
  3. luiztauffer commented on Sep 29, 2021

    @luiztauffer
    ContributorAuthor

    hey @Karan-S-Mittal , that looks good!
    But this is not being controlled by DDK, instead it is being defined by daq.DarkThemeProvider, right?
    What we would like it for DDK to change those color properties, from slider and LEDDisplay

  4. Karan-S-Mittal commented on Sep 29, 2021

    @Karan-S-Mittal
    Contributor

    ok, I will make a example with that and see if it doesn't give any bugs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions