This repository was archived by the owner on Aug 29, 2025. It is now read-only.
Repository navigation
Conversation
AnnMarieW
requested review from
Marc-Andre-Rivet,
alexcjohnson and
rpkyle
as code owners
January 17, 2021 17:06
Collaborator
|
Hmm an ending |
Contributor
Author
|
Actually, this PR is no longer needed. The component generator also updates descriptions so they end with a period, so now the last character of the last prop won't ever be a double quote. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This small change is needed to work with dash #1531
One of the changes in #1531 is to sort the props. A docstring comment that ends with a
"in the last prop will cause the component docstring to end with 4 double quotes""""which causes an error in the build. Using a single quote fixes this error.