Repository navigation
The deck shape panel stays tidy at extreme counts (spec 077, closes #320) - #331
Merged
Merged
Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
…, variant widths Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Red before the partial and the CSS (spec 077). Request, 3 of 4 fail: the 6+ count reads 1,357 not 1.4k (AC-1.2), the segment labels read W 2,591 not W 2.6k (AC-2.1), no c-manacap__item (AC-4.2); the types' exact counts example is a guard and is green. System, 5 of 12 fail: AC-1.3 (320, 345 and the 366px frame: count room -5.43, -1.85, -1), AC-2.2 (320: labels wrap to 2 lines; 345: 50.8px in a 51px segment), AC-3.1 and AC-3.1b (flex rows: counts end at different x), AC-4.3 (no c-manacap__item, so itemLines is empty). The 7 other system examples (six can-fail variants and the AC-3.2 floor) are green, as predicted; the AC-4.3 variant is green for the wrong reason until the items exist. The stale AC-5.3 comment is rewritten. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
…aption as items (#320) Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
…hole (#320) Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Factory data, placeholder card images. 375px, 335px and 640px frames and the 1280px aside, light and dark. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
…l, tie the variants to their cause (#320) Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
…spec 0.3.3) CI measured the six-character label at 44.70px against the Mac's 43.56px in a 46px content width. The 2px gap came from a Mac measurement; the criterion is about wrapping and overflow, so a label fits when it is on one line and within its segment. The unabbreviated variant still fails through the lines clause. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
plainprogrammer
marked this pull request as ready for review
November 12, 2026 04:36
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #320
The deck shape panel stays tidy at extreme counts (a 6+ column of 1,357, five mana segments of about 2,591, a "9,999 proxy" Card types row) on a 320px to 360px viewport and in the 320px aside. Spec 077 (spec 0.3.2, plan, verification).
What changes, per limit of #320
aria-labelaria-labelkeep the exact countsubgridof it, so counts end at one x; the name wraps at five-digit countsOne ruling by the maintainer (decision 2, option A): the 10% rule that hides a label (spec 060 decision 4) stays. A mana segment narrower than its label (labels of four, five and six characters need about 14%, 17% and 20% of the bar at a 320px viewport) is a documented limit, offered as its own issue: #330.
Code
app/models/mtg/deck_shape.rb(short_count,caption_items, two constants),app/views/mtg/deck_shapes/_parts.html.erb, and two DeckShape blocks ofadditions.css(10 lines added, 4 removed). The deck core files are untouched. The documents:DeckShape.md, three previews, the area doccollection-and-lots.md(paragraph, Named constants, Issues, Sources, log) and the specs index; specs 060 and 069 are superseded in part and not edited.Evidence
Factory data, placeholder card images. Spec 069's worst-case fixture plus a "9,999 proxy" row. Before is the unchanged code, after is this branch; light and dark.
The change is CSS and number formatting with no flow, so static shots stand in for a GIF.
Tests
9c1d80a2): the abbreviation and caption items (model), the rendered markup (request), and a nesteddescribein the existing shape-panel system spec that measures the panel at a 320px, 345px and 360px viewport, a 366px frame, a 640px frame and the 1280px aside, in both themes. Frames are sized from the measured scrollbar and read againstclientWidth. Every geometry example has a failing variant that injects the old text or rule.bin/ci: 4,416 examples, 0 failures, 1 pending; rubocop, YARD (0 warnings) and the comment ratchet green. The Mode B review (read-only Opus) is recorded inverification.md: SPEC-ALIGNED WITH MINOR FINDINGS, no blocking or major findings, the minors fixed.Notes for the reviewer
docs/lessons/.additions.css.🤖 Generated with Claude Code