Repository navigation
fix(design-system): a select's label keeps a gap to its select (#317) - #329
Merged
Merged
Conversation
#317) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…#317) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…317) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
… it uses (#317) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…ow (#317) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
# Conflicts: # docs/specs/README.md
…ared component (#317) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #317
On number entry the "Language" label touched its select:
.c-selecthad no gap between its name and the select, and Language is the onlyc-selectwhose name is shown (the Location and Set selects hide theirs withc-sr). One rule in the component fixes it, with a design-system token and no page rule:.c-select { display: inline-flex; align-items: center; gap: var(--space-2); }, inside the "Select inside the filter bar" block ofadditions.css. The touch-floor rules (spec 072, #316) are untouched.Direct fix, no spec or plan (route confirmed by the coordinator): the evidence is
docs/specs/076-select-label-gap/verification.md.What changed
additions.css: the one rule above, with a comment saying why.spec/system/select_label_gap_spec.rb, written first and seen red (expected 0 to be within 0.5 of 8): Language's gap equals the--space-2token (read from the browser) at 1280px and in the 360px frame; the Location, card search Set and proxy chooser Set selects start at their label's left edge, so a hidden name put in flow would fail them.FilterSelect.md,NumberEntry.md, a row indocs/specs/README.md, a lesson.Checks
c-selectuse audited; there is noc-selectSort in the app.bin/ciran in the pre-push hook and run again in CI.verification.md: SPEC-ALIGNED WITH FINDINGS (no blocking or major findings; all actionable ones taken).Screenshots
Factory data, placeholder card images. "Before" is emulated by injecting the old behaviour as a
<style>. Desktop (1280) and 360px, light and dark; all indocs/specs/076-select-label-gap/screenshots/.Number entry's language row, desktop (the gap is 0 before and 8px after):
Number entry at 360px:
Card search at 360px, after (unchanged: the before and after pairs are byte-identical; the full set, with the collection page and desktop widths, is in the folder):
🤖 Generated with Claude Code