Repository navigation
Bump solid_queue to 1.7.2; Retry now keeps the Active Job arguments (#283) - #284
Merged
Merged
Conversation
1.7.2 gives a concurrency slot back only to the semaphore it came from (rails/solid_queue#831). It fails spec 055's run_now example, which compares the whole stored arguments column; the next commit narrows it. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…283 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This was referenced Nov 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #283. Replaces Dependabot's #277, which is stale: its branch predates several merges.
2ccb05ffbumpssolid_queuefrom 1.7.0 to 1.7.2. This changes only the gem's version and checksum lines inGemfile.lock, as chore(deps): Bump solid_queue from 1.7.0 to 1.7.2 #277 did, with no other dependency changes. 1.7.2 gives a concurrency slot back only to the semaphore it came from (Give concurrency slots back only to the semaphore they came from rails/solid_queue#831). To do that, it records the semaphore in the job's storedargumentswhen it dispatches the job.8bd82ecachanges spec 055'srun_nowexample, following the maintainer's ruling on solid_queue 1.7.2 writes its concurrency lock into a job's arguments, failing spec 055's Retry now check (#277) #283 (option A). FR-2's "leaving its Active Job id and arguments as they were" means the job's id, Active Job id and Active Job arguments (arguments["job_id"],arguments["arguments"]), not Solid Queue's own bookkeeping keys. The example now compares those fields and checks that the arguments are still["mtg", "manual"].7f4db21dadds that reading tocatalog-operations.md's "Retry now" invariant, citing solid_queue 1.7.2 writes its concurrency lock into a job's arguments, failing spec 055's Retry now check (#277) #283 as its source, and adds solid_queue 1.7.2 writes its concurrency lock into a job's arguments, failing spec 055's Retry now check (#277) #283 to Sources.Checks
spec/models/catalog/operation/queue_spec.rbfailed only:123, as on chore(deps): Bump solid_queue from 1.7.0 to 1.7.2 #277. After the change it passes, 23 examples.spec/models/catalog/operation,spec/jobs,spec/requests/adminand the admin jobs and catalog system specs pass, 188 examples with 0 failures.bin/cipassed in the pre-push hook at7f4db21d.🤖 Generated with Claude Code