Repository navigation
feat: open a location's lots in bulk mode from its removal refusal (#187) - #280
Merged
Merged
Conversation
Spec 059 (approved at Gate A) and its plan, plus the index row and the supersession marks on specs 006, 032 and 041. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Blue binder holding 12 copies in 3 lots, light and dark, at 1280px and in a 360px frame. Factory data, placeholder printings. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Model, request and system examples for spec 059, the refusal page's locations_spec example changed to hold the shortcut, and tab_to moved to spec/support/keyboard_helpers.rb (the body no longer counts as focused). Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
…h every lot selected (#187) Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
#187) Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Distillation log row and the index row (Frozen, plan retirement owed). Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
… (spec 027 D4) Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
…tion log Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #187 (roadmap item 14c). Spec 059, approved by the maintainer at Gates A and B.
What changes
A location that still holds lots refuses its removal. The refusal page now has a primary button, Move them in bulk mode, first in its actions row. It is a POST (
POST /locations/:location_id/selection,Locations::SelectionsController#create), never a link (spec 006 FR-1). It opens bulk mode filtered to that location (/collection?bulk=1&location=<id>) with every matching lot selected, soMove to…is one press away. Another account's location answers 404.BulkSelection#restart!gainsall:so the selection is written in its one transaction.The button is on both
GET /locations/:id/removal/newand the 409 page of a refusedDELETE; not on an empty location's confirmation page or the list.Supersedes
Spec 041 decision 5, spec 006 FR-4 and Story 4's "Edit many as the only way in", spec 032 AC-5.2 and AC-5.4 (recorded in the index and the area doc, specs untouched).
Screenshots (refusal page of "Blue binder", 12 copies in 3 lots)
Before / after, in
docs/specs/059-bulk-mode-from-location-refusal/screenshots/:before-refusal-{desktop,phone}-{light,dark}.jpg,after-refusal-…, andafter-bulk-table-…(the page the button opens).Verification
bin/ciondb96a5e4and passed; the suite counts 3064 examples. Targeted run before it: 2130 examples, 0 failures.verification.md. Spec and plan each had two Opus review rounds.tab_tomoved tospec/support/keyboard_helpers.rbastab_to_textand no longer matches the focused<body>, so the existing "Back to locations" keyboard check inlocations_spec.rbnow really tabs.🤖 Generated with Claude Code