Repository navigation
test(bulk-move): wait for the move page before clicking Move (closes #233) - #235
Merged
Merged
Conversation
On the bulk page a bare click_on "Move" partially matches the "Move to…" button, so while the move page hadn't rendered yet the example clicked "Move to…" again and found no #to field. It failed twice on 2026-11-09 (#229's pre-push, PR #232's shard 2). Wait for the move page's heading, as the file's other examples do, and click with exact: true. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #233.
spec/system/bulk_move_spec.rb:54clicked a bareclick_on "Move"right after following "Move to…". On the bulk page, Capybara's:smartmatch falls back to a partial match, so while the move page hadn't rendered yet it clicked "Move to…" again, anddocument.getElementById('to')was null.It failed twice on 2026-11-09:
bin/ci, seed 56686;RSpec (2/4), run 42656481520, seed 42590.Fix: wait for the move page's heading, as the file's other examples do, then
click_on "Move", exact: true. The other examples that click Move already wait on the page'sh1or the To select.Evidence:
bin/cion this head.🤖 Generated with Claude Code