You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I'm happy to take this on. I don't have a strong preference for linter settings (I personally prefer using Prettier for style enforcement since it stops the majority of style preference arguments in their tracks 😆 ). Would an org-wide shared config be useful here? Or is that impractical given that the same folks won't be working on all the packages?
If a shared config doesn't seem like the way to proceed, I'll make a PR copying over the existing non-repo specific configuration from the nodejs/node .eslintrc.js and we can discuss there.
I don't think the nodejs/node config should be replicated/copied to other projects. It is a result the history of the project and has a lot of special rules that are there only to avoid big changes to the code base.
Activity
joesepi commentedon May 14, 2021
It would be nice to get as close to
nodejs/nodeas possible.joesepi commentedon May 14, 2021
For reference: https://github.com/nodejs/node/blob/master/.eslintrc.js
ljharb commentedon May 14, 2021
I don't think that should be a goal; node's linter settings are often exceedingly unidiomatic for the ecosystem.
kaicataldo commentedon May 17, 2021
I'm happy to take this on. I don't have a strong preference for linter settings (I personally prefer using Prettier for style enforcement since it stops the majority of style preference arguments in their tracks 😆 ). Would an org-wide shared config be useful here? Or is that impractical given that the same folks won't be working on all the packages?
If a shared config doesn't seem like the way to proceed, I'll make a PR copying over the existing non-repo specific configuration from the nodejs/node
.eslintrc.jsand we can discuss there.ljharb commentedon May 17, 2021
Imo prettier, if used, should only be used via eslint config :-)
I think that its an impractical mandate for the reason you mention, but a shared config is a good idea for common patterns.
The most common idiom in the ecosystem, by any metric, is the Airbnb config combined with prettier’s config. Is there a reason not to just use those?
kaicataldo commentedon May 17, 2021
No objections here
targos commentedon May 17, 2021
I don't think the
nodejs/nodeconfig should be replicated/copied to other projects. It is a result the history of the project and has a lot of special rules that are there only to avoid big changes to the code base.mhdawson commentedon May 31, 2021
for https://github.com/pkgjs/support I used eslint with semistandard - https://github.com/pkgjs/support/blob/main/.eslintrc.json