Repository navigation
Conversation
This allows moving the pixie-vm binary without breaking everything or having to pass -l on every single call.
Member
|
Sorry for the late response... While we need to support installing pixie separate from its libraries, I think we should do it "cleaner". I'd prefer switching between the current path local to Something like: if USE_GLOBAL_LOADPATH:
system_path = ... # from LIB_PATH or similar
else:
system_path = ... # local to `pixie-vm` |
Author
|
Sorry for the also-late response :P Understood. I'm going to close* this PR and use that approach. My reasoning for doing it this (messy) way was to preserve as much existing behavior as possible. I should have a followup PR up this weekend. *Closing because I don't see much point in having a big revert commit or overwriting that branch. Lemme know if you'd rather keep this centralized on this PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR was motivated by me wanting to create an AUR package for pixie, but being blocked by the hard-coded
load-paths.This PR contributes the following changes:
PIXIE_PATHenvironment variable whenpixie-vmis run/usr/share/pixiemake installtarget that more-or-less conforms to the variable conventions.The order of the load-paths is [user path (-l), pixie-vm directory, PIXIE_PATH, system path].
Note that the pixie-vm path seems weird when doing a system install, because
/usr/binand a bunch of directories related to it end up inload-paths.