Repository navigation
concat always returns a vector #474
Description
Pixie's concat always returns a vector, whereas in Clojure, it returns a lazy seq:
Pixie:
(concat (take 2 (range 1)) (take 1 (repeat nil)))
;;=> [0 nil]Clojure:
(concat (take 2 (range 1)) (take 1 (repeat nil)))
;;=> (0 nil)
(realized? (concat (take 2 (range 1)) (take 1 (repeat nil))))
;;=> falseI think the Clojure behaviour is more desirable here.
Activity
jmglov commentedon Dec 15, 2015
@thomasmulvaney @mpenet What do you guys think about this one?
thomasmulvaney commentedon Jan 7, 2016
I agree. One would expect
concatto behave lazily.mpenet commentedon Jan 7, 2016
+1 for lazy concat, just for clojure compatibility's sake.
jmglov commentedon Jan 7, 2016
This might be a good one for me to take a swing at into order to get familiar with Pixie's sequences implementation. I'll see what I can do. :)
brian-dawn commentedon Feb 25, 2016
@jmglov Were you still planning on fixing this? If not I would be happy to work on it.
Also I noticed something interesting with regards to performance, anyone have any idea why this is?
I guess I would expect these to be fairly similar from a performance perspective.
jmglov commentedon Feb 26, 2016
@brian-dawn I've gotten really busy at work with non-Pixie stuff, so please feel free to run with it.
As for your performance question, I'm really not sure.