Repository navigation
Add safeguards for constant subprocess commands - #420
Merged
Merged
Conversation
clavedeluna
suggested changes
Mar 29, 2024
clavedeluna
left a comment
clavedeluna
left a comment
Contributor
There was a problem hiding this comment.
- It's a bit weird that the existing unit tests now have this "cmd" which isn't defined in the code snippet of the test. Do you think it makes sense to define it with an appropriate cmd value (argument passed from a func?)
- If cmd as a func arg isn't a good simple case for ^, could you add a test case for
def func(cmd): subprocess.run(cmd....
drdavella
force-pushed
the
process-sandbox-exclude-hardcoded
branch
from
April 2, 2024 13:57
f0db641 to
d3dec3d
Compare
|
clavedeluna
approved these changes
Apr 2, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Prevent false positives when adding hardening for subprocess commands
Description
sandbox-process-creationwhen arguments are literals #263