Repository navigation
Sonar tmpfile codemod - #393
Merged
Merged
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| @@ -0,0 +1,3 @@ | |||
| import tempfile | |||
|
|
|||
| tempfile.mktemp() | |||
Check failure
Code scanning / SonarCloud
Insecure temporary file creation methods should not be used
clavedeluna
force-pushed
the
sonar-tempfile-371
branch
from
April 1, 2024 12:29
e9d2da6 to
bf5925a
Compare
clavedeluna
marked this pull request as ready for review
April 1, 2024 12:35
andrecsilva
approved these changes
Apr 2, 2024
andrecsilva
left a comment
andrecsilva
left a comment
Contributor
There was a problem hiding this comment.
Pending the test failures, this looks good to me.
clavedeluna
force-pushed
the
sonar-tempfile-371
branch
from
April 2, 2024 12:13
bf5925a to
94689a7
Compare
|
drdavella
approved these changes
Apr 2, 2024
| guidance_explained=CORE_METADATA["fix-missing-self-or-cls"].guidance_explained, | ||
| need_sarif="Yes (Sonar)", | ||
| ), | ||
| "secure-tempfile-S5445": DocMetadata( |
Contributor
There was a problem hiding this comment.
Not necessarily for this PR but we should be able to rewrite this whole section in terms of a dict comprehension and avoid a lot of duplication.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Added a sonar codemod for
secure-tempfileDescription
Closes #371